Skip to content

update pyproject.toml to support Python 3.14 #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
methane merged 7 commits into from
Feb 8, 2026
Merged

update pyproject.toml to support Python 3.14 #772

methane merged 7 commits into from
Feb 8, 2026

Conversation

@MysticEntity-dev
Copy link
Contributor

@MysticEntity-dev MysticEntity-dev commented Dec 16, 2025

Suggested changes to fix deprecation and changes to format of project.license in python 3.14: C:\Users\XXX\AppData\Local\Temp\pip-build-env-cc_fwjqb\overlay\Lib\site-packages\setuptools\config_apply_pyprojecttoml.py:82: SetuptoolsDeprecationWarning: project.license as a TOML table is deprecated
!!

          ********************************************************************************
          Please use a simple string containing a SPDX expression for `project.license`. You can also use `project.license-files`. (Both options available on setuptools>=77.0.0).

          By 2026-Feb-18, you need to update your project and remove deprecated calls
          or your builds will no longer be supported.

          See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
          ********************************************************************************

  !!
    corresp(dist, value, root_dir)
  C:\Users\XXX\AppData\Local\Temp\pip-build-env-cc_fwjqb\overlay\Lib\site-packages\setuptools\config\_apply_pyprojecttoml.py:61: SetuptoolsDeprecationWarning: License classifiers are deprecated.
  !!

          ********************************************************************************
          Please consider removing the following classifiers in favor of a SPDX license expression:

          License :: OSI Approved :: GNU General Public License v2 or later (GPLv2+)

          See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
          ********************************************************************************

  !!
    dist._finalize_license_expression()
  C:\Users\XXX\AppData\Local\Temp\pip-build-env-cc_fwjqb\overlay\Lib\site-packages\setuptools\dist.py:759: SetuptoolsDeprecationWarning: License classifiers are deprecated.
  !!

          ********************************************************************************
          Please consider removing the following classifiers in favor of a SPDX license expression:

          License :: OSI Approved :: GNU General Public License v2 or later (GPLv2+)

          See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
          ********************************************************************************

And also to fix build errors when using the 64 bit MariaDB Connector C, but not sure if this is the correct way.

@codecov
Copy link

codecov bot commented Dec 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.84%. Comparing base (e2a908b) to head (a8cd23e).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   88.86%   88.84%   -0.02%     
==========================================
  Files           7        7              
  Lines         548      556       +8     
==========================================
+ Hits          487      494       +7     
- Misses         61       62       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MysticEntity-dev MysticEntity-dev marked this pull request as draft December 16, 2025 15:47
@MysticEntity-dev
Copy link
Contributor Author

MysticEntity-dev commented Dec 16, 2025

Ofc this breaks compatibility with all previous python versions. Suggestions welcome as I don't have a lot of time and are quite new to building packages for pip

methane
methane reviewed Feb 3, 2026
View reviewed changes
setup.py Outdated
connector = os.path.join(
os.environ["ProgramFiles"], "MariaDB", "MariaDB Connector C"
os.environ["ProgramFiles"], "MariaDB", "MariaDB Connector C",
os.environ["ProgramFiles"], "MariaDB", "MariaDB Connector C 64-bit",
Copy link
Member

@methane methane Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have Windows box now. Is this current default location of official installer?

@methane
Update required Python version to 3.10
df9024d 
Updated the required Python version from 3.8 to 3.10 and removed support for 3.8 and 3.9.
@methane
Simplify connector path retrieval in setup.py
e9fbedd 
Remove redundant path for MariaDB Connector C.
@methane
Fix indentation in setup.py for connector path
a8cd23e
@methane methane marked this pull request as ready for review February 8, 2026 07:59
@methane methane changed the title Python314 support update setup.py file to support Python 3.14 Feb 8, 2026
@methane methane changed the title update setup.py file to support Python 3.14 update pyproject.toml to support Python 3.14 Feb 8, 2026
@methane methane merged commit d0371b2 into PyMySQL:main Feb 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MysticEntity-dev @methane